-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: hello world playground run with success and failure tests #2513
base: main
Are you sure you want to change the base?
Conversation
26193cb
to
e52746d
Compare
Tests are failing because the Hello world message is localized. Checking for only the world icon to be present |
ce32ed4
to
6f5054f
Compare
Without localization issues another error class shows.
|
I looked again into this and it seems I used a not ideal directory for the hello-world page as the "types-and-values" directory does not have this file in e.g. pl translation $ find comprehensive-rust-* -name "hello-world.html"
comprehensive-rust-en/html/hello-world/hello-world.html
comprehensive-rust-en/html/hello-world.html
comprehensive-rust-en/html/types-and-values/hello-world.html
comprehensive-rust-en/pandoc/pdf/src/hello-world/hello-world.html
comprehensive-rust-pl/html/hello-world/hello-world.html
comprehensive-rust-pl/html/hello-world.html using the hello-world directory redirection Line 193 in de8ae4f
|
6f5054f
to
2992180
Compare
Happy New Year!
Perhaps a good first step would be to limit these tests to the English text? The The JavaScript tests are not there to ensure that translations compile, their goal is to ensure that the JS code works. I think it's sufficient to test with just the English base version. One day (#1390), we might do some localization with the JS code, but not today 😄 |
Yes, I agree, testing the English base version is the best approach. If there is something that depends on something language specific, this could be added later. |
Implement two tests for the rust playground: