Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LazyClassKey proguard file issues. #4556

Closed
wants to merge 0 commits into from
Closed

Conversation

copybara-service[bot]
Copy link

Fix LazyClassKey proguard file issues.

  • Fixes the name of the proguard file to contain an underscore between the package and simple names (e.g. test.FooModule was testFooModule_LazyClassKeys.pro and is now test_FooModule_LazyClassKeys.pro).
  • Fixes incremental processing by adding the originating element to the writeResource call ([KSP] Incremental symbol processing not working (or working poorly) #4549).
  • Fixes bug where StringBuilder was declared outside module for-loop, which could lead to duplicate entries across proguard rules for different modules.
  • Fixed ClassName#toString() usage to ClassName#canonicalName(), since toString() is ambiguous and will silently break things when we migrate to XClassName.
  • Added test coverage for the proguard file name and contents.

Fixes #4549

RELNOTES=Fixes #4549: Fixes incremental processing for LazyClassKey proguard files by adding the originating element to the writeResource call.

@copybara-service copybara-service bot closed this Dec 27, 2024
@copybara-service copybara-service bot deleted the test_709861817 branch December 27, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[KSP] Incremental symbol processing not working (or working poorly)
0 participants