Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional allow attributes & tags #259

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dab246
Copy link

@dab246 dab246 commented Oct 23, 2024

No description provided.

Copy link

google-cla bot commented Oct 23, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jonasfj jonasfj self-requested a review February 4, 2025 08:44
@jonasfj
Copy link
Member

jonasfj commented Feb 4, 2025

At the moment this package is aimed at aligning with github gfm sanitization rules:
https://github.com/jch/html-pipeline/blob/master/lib/html/pipeline/sanitization_filter.rb

Arguably, these have changed, I don't think github uses that code anymore.

But I'm hesitant to just add features. If there is a lot of community members that would rather have an HTML sanitation package with more advanced features I'm inclined to suggest that you write such a package, publish and maintain it yourself.

Feel free to fork this package and give it a new better name, ideally collaborate with others.
I see that @jawad111 has suggestions in #263.

Honestly, I'd be more than happy for package:sanitize_html to have a link in the README.md telling users that if they want advanced features they should consider one of the following packages... (assuming you make a good package obviously 🤣)


On topic of this PR, I might get around to doing a review, but again, I'm hesitant to accept more features. Maybe, if it turns out we need them elsewhere too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants