Skip to content

Fix #1058 #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix #1058 #1121

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35b7bb4
Fix #1058
stepeos Sep 16, 2025
9e8f5f1
fix for windows
stepeos Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmake/draco_targets.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ macro(draco_add_executable)
endif()

if(exe_LIB_DEPS)
if(CMAKE_CXX_COMPILER_ID MATCHES "^Clang|^GNU")
if(UNIX AND NOT APPLE AND (CMAKE_CXX_COMPILER_ID MATCHES "^(Clang|GNU)$"))
# Third party dependencies can introduce dependencies on system and test
# libraries. Since the target created here is an executable, and CMake
# does not provide a method of controlling order of link dependencies,
Expand Down