create GitHub workflow #176
Conversation
Signed-off-by: David Liu <[email protected]>
Signed-off-by: David Liu <[email protected]>
davidkhala
requested review from
xiashang0624,
yzhvictor,
ajwelch4,
paolomorandini,
mjquinn-google,
arotenberg-google and
shevek-google
as code owners
.github/workflows/python-package.yml
Outdated
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| python-version: ["3.8", "3.9", "3.10"] |
There was a problem hiding this comment.
Nit: We claim python 3.7.2 in deps, but don't test it here.
There was a problem hiding this comment.
@shevek-google Good suggestion.
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| python-version: ["3.7", "3.8", "3.9", "3.10"] |
There was a problem hiding this comment.
@davidkhala We already use nox to run tests under different Python versions:
- https://github.com/google/dwh-migration-tools/blob/main/client/noxfile.py#L52
- https://github.com/google/dwh-migration-tools/blob/main/client/CONTRIBUTING.md#test
Also, we have formatting, linting and type checking:
So far we have just been running everything manually. Is it possible to take advantage of that here? @paolomorandini does it matter whether these checks are run via GH actions or our existing kokoro scripts?
There was a problem hiding this comment.
I think we can use GH actions as long as we don't need secrets.
There was a problem hiding this comment.
Integration/load tests will need secrets.
There was a problem hiding this comment.
@ajwelch4 agree, will take a look to see if we can reuse those existing test script into GH workflow.
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| python-version: ["3.7", "3.8", "3.9", "3.10"] |
There was a problem hiding this comment.
Integration/load tests will need secrets.
Along with an adjustment to cover more general install cases