Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the bin/dwh-migration-client script, as the executable it referred to no longer exists #196

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arotenberg-google
Copy link
Collaborator

@arotenberg-google arotenberg-google commented Apr 11, 2023

The docs on the GCP site and the bin scripts included in the release zip refer to an executable named dwh-migration-client, but that command doesn't exist anymore, there's only run.sh and bqms-run.

There will need to be a separate Google-internal change to update the GCP docs.

The current behavior of the client on a clean pip install can be confirmed using this Dockerfile:

> whereis dwh-migration-client
dwh-migration-client:
> whereis bqms-run            
bqms-run: /usr/local/bin/bqms-run

@arotenberg-google arotenberg-google added bug Something isn't working python Pull requests that update Python code labels Apr 11, 2023
@arotenberg-google arotenberg-google self-assigned this Apr 11, 2023
@shevek-google
Copy link
Collaborator

Should we update the code to match the docs, or the docs to match the code? dwh-migration-client is a better name than run.sh

@ajwelch4
Copy link
Collaborator

ajwelch4 commented Apr 15, 2023

Both run.sh and bqms-run are admittedly bad names. I am not good at naming ;-).

If we exchange $SCRIPT_DIR (defined here) for $PWD then we should be able to pull run.sh into a top-level bin directory as long as $PWD contains input and config dirs. And of course we can rename run.sh as well and update the docs.

clean.sh and deprovision.sh are trivial and could just be deleted. provision.sh shows all of the gcloud commands you would need to run if you were starting from zero without a project and needed to provision the correct resources to run locally or on Cloud Run. It is truly meant as an example as no one really uses a bash script with gcloud commands as a devops tool. I created it simply to spin up demo environments from scratch and as executable documentation. Not sure where that belongs, if anywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants