Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate FhirStoreUtilTest to Junit5 #1135

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

meetmehta1198
Copy link

@meetmehta1198 meetmehta1198 commented Aug 1, 2024

Description of what I changed

Fixes #1103

E2E test

TESTED:

Please replace this with a description of how you tested your PR beyond the
automated e2e/unit tests.

Checklist: I completed these to help reviewers :)

  • I have read and will follow the review process.

  • I am familiar with Google Style Guides for the language I have coded in.

    No? Please take some time and review Java and Python style guides.

  • My IDE is configured to follow the Google code styles.

    No? Unsure? -> configure your IDE.

  • I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)

  • I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.

  • All new and existing tests passed.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@meetmehta1198
Copy link
Author

This PR solve some of the test cases based on the Issue #1103

@chandrashekar-s

@meetmehta1198
Copy link
Author

cc @bashir2

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.67%. Comparing base (b03c2c7) to head (b209ce2).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1135      +/-   ##
============================================
- Coverage     51.76%   51.67%   -0.09%     
+ Complexity      669      668       -1     
============================================
  Files            95       95              
  Lines          5612     5612              
  Branches        731      731              
============================================
- Hits           2905     2900       -5     
- Misses         2425     2430       +5     
  Partials        282      282              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@chandrashekar-s chandrashekar-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @meetmehta1198 for the changes and apologies for the delay in the review. There are few comments, can you please have a look.

@meetmehta1198
Copy link
Author

@chandrashekar-s can you please review this PR

Copy link
Collaborator

@chandrashekar-s chandrashekar-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @meetmehta1198 for these changes. I am extremely sorry for delaying the review for this PR as I was involved in some activities of another project. The changes look good, there is only one minor comment. Can you please have a look at that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate all unit test cases to Junit 5 platform
3 participants