-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate FhirStoreUtilTest to Junit5 #1135
base: master
Are you sure you want to change the base?
Conversation
This PR solve some of the test cases based on the Issue #1103 |
cc @bashir2 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1135 +/- ##
============================================
- Coverage 51.76% 51.67% -0.09%
+ Complexity 669 668 -1
============================================
Files 95 95
Lines 5612 5612
Branches 731 731
============================================
- Hits 2905 2900 -5
- Misses 2425 2430 +5
Partials 282 282 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @meetmehta1198 for the changes and apologies for the delay in the review. There are few comments, can you please have a look.
pipelines/common/src/test/java/com/google/fhir/analytics/FhirStoreUtilTest.java
Outdated
Show resolved
Hide resolved
pipelines/common/src/test/java/com/google/fhir/analytics/FhirStoreUtilTest.java
Show resolved
Hide resolved
4145b99
to
7b0ecdd
Compare
7b0ecdd
to
e22308e
Compare
@chandrashekar-s can you please review this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @meetmehta1198 for these changes. I am extremely sorry for delaying the review for this PR as I was involved in some activities of another project. The changes look good, there is only one minor comment. Can you please have a look at that?
e22308e
to
a709fc7
Compare
a709fc7
to
bc37de5
Compare
Description of what I changed
Fixes #1103
E2E test
TESTED:
Please replace this with a description of how you tested your PR beyond the
automated e2e/unit tests.
Checklist: I completed these to help reviewers :)
I have read and will follow the review process.
I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.
My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.
I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
I ran
mvn clean package
right before creating this pull request and added all formatting changes to my commit.All new and existing tests passed.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master