Delete resources in the sink DB and FHIR server #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1183 +/- ##
============================================
+ Coverage 51.34% 51.43% +0.08%
- Complexity 711 715 +4
============================================
Files 95 95
Lines 5886 5907 +21
Branches 781 787 +6
============================================
+ Hits 3022 3038 +16
- Misses 2578 2581 +3
- Partials 286 288 +2 ☔ View full report in Codecov by Sentry. |
bashir2
reviewed
Sep 13, 2024
pipelines/batch/src/main/java/com/google/fhir/analytics/ConvertResourceFn.java
Outdated
Show resolved
Hide resolved
pipelines/batch/src/main/java/com/google/fhir/analytics/ConvertResourceFn.java
Outdated
Show resolved
Hide resolved
|
@bashir2 Sorry for the delay in addressing the review comments. Please have a look at my recent changes. |
bashir2
approved these changes
Oct 21, 2024
pipelines/batch/src/main/java/com/google/fhir/analytics/ConvertResourceFn.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Fixes #588
Delete the FHIR resources in the Sink DB and Sink FHIR servers during export.
E2E test
Relied on e2e tests.
TESTED:
Manually tested by deleting the resources from the source FHIR server and verifying the same from the sink systems.
Checklist: I completed these to help reviewers :)
I have read and will follow the review process.
I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.
My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.
I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
I ran
mvn clean packageright before creating this pull request and added all formatting changes to my commit.All new and existing tests passed.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master