Assert that disassemble was successful

google · Jul 26, 2023 · 6e99b60 · 6e99b60
1 parent f536c70
commit 6e99b60
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/libs/filamat/src/GLSLPostProcessor.cpp b/libs/filamat/src/GLSLPostProcessor.cpp
@@ -616,9 +616,11 @@ void GLSLPostProcessor::fixupClipDistance(
     if (!config.usesClipDistance) {
         return;
     }
+    // This should match the version of SPIR-V used in GLSLTools::prepareShaderParser.
     SpirvTools tools(SPV_ENV_UNIVERSAL_1_3);
     std::string disassembly;
-    tools.Disassemble(spirv, &disassembly);
+    const bool result = tools.Disassemble(spirv, &disassembly);
+    assert_invariant(result);
     if (filamat::fixupClipDistance(disassembly)) {
         spirv.clear();
         tools.Assemble(disassembly, &spirv);