Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Python onefile deserialization #8544

Closed
wants to merge 1 commit into from
Closed

Fix Python onefile deserialization #8544

wants to merge 1 commit into from

Conversation

sethraymond
Copy link

With include_dependence_headers set to false, fbs files that include from other fbs files would not properly deserialize.

Fixes #8543

@sethraymond
Fix Python onefile deserialization
c61d837 
With include_dependence_headers set to false, fbs files that include
from other fbs files would not properly deserialize.

Fixes google#8543
@github-actions github-actions bot added c++ codegen Involving generating code from schema python labels Feb 27, 2025
@sethraymond
Copy link
Author

Turns out this doesn't work with -I <path>, particularly if the path is absolute (it results in something like import home.user.path.to.fbs.directory.module). Does --gen-onefile require no include directives in the fbs file? Or should we attempt to traverse the include tree and concatenate each of the generated files together into the base file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ codegen Involving generating code from schema python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python --gen-onefile option not respecting include directive
1 participant
@sethraymond