-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edu AU VIC WA NT Arrows Guides: Version 1.001 added #7873
base: main
Are you sure you want to change the base?
Conversation
Taken from the upstream repo https://github.com/SorkinType/VICWANTSchoolhandAustralia at commit SorkinType/VICWANTSchoolhandAustralia@7ebdd5a.
b350323
to
2068515
Compare
FontBakery reportfontbakery version: 0.12.7 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [2] EduAUVICWANTArrowsGuides[wght].ttfAll other checks[21] EduAUVICWANTArrowsGuides[wght].ttf🔥 FAIL Checking correctness of monospaced metadata.
🔥 FAIL MaxAdvanceWidth is consistent with values in the Hmtx and Hhea tables?
🔥 FAIL Whitespace glyphs have ink?
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
But: font copyright string has 'https://github.com/SorkinType/VICWANTSchoolHandAustralia' and OFL text has 'https://github.com/SorkinType/VICWANTSchoolHandAustralia' [code: mismatch]🔥 FAIL Shapes languages in all GF glyphsets.
🔥 FAIL Combined length of family and style must not exceed 32 characters.
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
🔥 FAIL Copyright notices match canonical pattern in fonts
[code: mismatch] 🔥 FAIL Check Google Fonts glyph coverage.
Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]
|
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 8 | 6 | 49 | 10 | 175 | 0 |
0% | 0% | 3% | 2% | 20% | 4% | 71% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
Now we have the apex VF onboarded I'm going to work on the variants. This font only contains A-Z a-z 0-9 and space, so many of the fontbakery fails are unsurprising. |
Numbers don't have any arrows. Is it intentional? @simoncozens @EbenSorkin ![]() |
Nope, that's a fix for @EbenSorkin please! |
I can make those. I forget if we even have dotted ones.
…-e.
On Fri, Jun 21, 2024 at 9:09 AM Simon Cozens ***@***.***> wrote:
Nope, that's a fix for @EbenSorkin <https://github.com/EbenSorkin> please!
—
Reply to this email directly, view it on GitHub
<#7873 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQUQXLZF2WV2WHPAICMGWLZIQQXHAVCNFSM6AAAAABJUA5K76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBSG4ZDGOBYGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@EbenSorkin do you have an estimated time for this fix? |
I can probably do it this evening.
Btw - I was looking at a spreadsheet with Dave and we agreed to do a
language extension for this a while ago and forgot because we wanted to get
it out and technically resolved first but I’ll want to get that started
when the moment comes that it’s not disruptive to do it.
…On Mon, Aug 19, 2024 at 2:21 PM Viviana Monsalve ***@***.***> wrote:
I can make those. I forget if we even have dotted ones.
@EbenSorkin <https://github.com/EbenSorkin> do you have an estimated time
for this fix?
—
Reply to this email directly, view it on GitHub
<#7873 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQUQXLB5IUAYZVDQHHGBP3ZSIZSBAVCNFSM6AAAAABJUA5K76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJXGE3DQMRRG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Let's solve and merge this PR with the basic initial glyph set that was agreed upon. Then, they can all be upgraded in a second phase related to adding language support. |
FontBakery reportfontbakery version: 0.12.10 Check results[23] EduAUVICWANTArrowsGuides[wght].ttf🔥 FAIL Checking correctness of monospaced metadata.
🔥 FAIL MaxAdvanceWidth is consistent with values in the Hmtx and Hhea tables?
🔥 FAIL Whitespace glyphs have ink?
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
But: font copyright string has 'https://github.com/SorkinType/VICWANTSchoolHandAustralia' and OFL text has 'https://github.com/SorkinType/VICWANTSchoolHandAustralia' [code: mismatch]🔥 FAIL Shapes languages in all GF glyphsets.
🔥 FAIL Combined length of family and style must not exceed 32 characters.
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
🔥 FAIL Copyright notices match canonical pattern in fonts
[code: mismatch] 🔥 FAIL Check Google Fonts glyph coverage.
Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]
|
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 8 | 6 | 52 | 10 | 175 | 0 |
0% | 0% | 3% | 2% | 21% | 4% | 70% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
Taken from the upstream repo https://github.com/SorkinType/VICWANTSchoolhandAustralia at commit SorkinType/VICWANTSchoolhandAustralia@7ebdd5a.
PR Checklist: