-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playwrite CO Guides: Version 1.002 added #8536
base: main
Are you sure you want to change the base?
Conversation
Taken from the upstream repo https://github.com/TypeTogether/Playwrite at commit TypeTogether/Playwrite@dc7ceab. Resolves #8535
This comment was marked as outdated.
This comment was marked as outdated.
FontBakery reportfontbakery version: 0.13.0a5 Checks with FATAL resultsThese must be addressed first. [1] PlaywriteCOGuides-Regular.ttfAll other checks[17] PlaywriteCOGuides-Regular.ttf
|
WARN messages | Languages |
---|---|
Some auxiliary glyphs were missing: ſ | de_Latn (German) and fr_Latn (French) |
Some auxiliary glyphs were missing: Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ | fi_Latn (Finnish) |
⚠️ WARN Check the direction of the outermost contour in each glyph
⚠️ WARNThe following glyphs have a counter-clockwise outer contour:
* cnct.cnt_b_z has a counter-clockwise outer contour
* cnct.cnt_b_z has a counter-clockwise outer contour
* cnct.cnt_b_z has a counter-clockwise outer contour
* cnct.cnt_c_z has a counter-clockwise outer contour
* cnct.cnt_c_z has a counter-clockwise outer contour
* cnct.cnt_f_z has a counter-clockwise outer contour
* cnct.cnt_o_n has a counter-clockwise outer contour
* cnct.cnt_o_n has a counter-clockwise outer contour
* cnct.cnt_o_n has a counter-clockwise outer contour
* cnct.cnt_o_z has a counter-clockwise outer contour
* 471 more.
Use -F or --full-lists to disable shortening of long lists.
[code: ccw-outer-contour]⚠️ WARN Do outlines contain any jaggy segments?
⚠️ WARNThe following glyphs have jaggy segments:
* A.cur (U+0041): L<<787.0,175.0>--<830.0,306.0>>/B<<830.0,306.0>-<783.0,226.0>-<732.5,165.5>> = 12.262109763757904
* A.cur.ini: L<<797.0,206.0>--<830.0,306.0>>/B<<830.0,306.0>-<783.0,226.0>-<732.5,165.5>> = 12.171345811249271
* r.mod.ini: L<<239.0,490.0>--<203.0,377.0>>/B<<203.0,377.0>-<228.0,418.0>-<253.0,445.5>> = 13.701954778116432
* r.mod.med: L<<265.0,490.0>--<228.0,377.0>>/B<<228.0,377.0>-<254.0,418.0>-<279.0,445.5>> = 14.250490794068266
[code: found-jaggy-segments]
⚠️ WARN Do outlines contain any semi-vertical or semi-horizontal lines?
⚠️ WARNThe following glyphs have semi-vertical/semi-horizontal lines:
* Wacute (U+1E82): L<<893.0,13.0>--<896.0,938.0>>
* Wacute (U+1E82): L<<948.0,1012.0>--<942.0,78.0>>
* Wcircumflex (U+0174): L<<893.0,13.0>--<896.0,938.0>>
* Wcircumflex (U+0174): L<<948.0,1012.0>--<942.0,78.0>>
* Wdieresis (U+1E84): L<<893.0,13.0>--<896.0,938.0>>
* Wdieresis (U+1E84): L<<948.0,1012.0>--<942.0,78.0>>
* Wgrave (U+1E80): L<<893.0,13.0>--<896.0,938.0>>
* Wgrave (U+1E80): L<<948.0,1012.0>--<942.0,78.0>>
* w.mod.fin: L<<104.0,11.0>--<102.0,489.0>>
* w.mod.ini: L<<104.0,11.0>--<102.0,489.0>>
* 6 more.
Use -F or --full-lists to disable shortening of long lists.
[code: found-semi-vertical]⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
⚠️ WARNThis font file does not have a 'meta' table.
[code: lacks-meta-table]
⚠️ WARN Check font follows the Google Fonts vertical metric schema
⚠️ WARNWe recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.977x (1977)
[code: bad-hhea-range]
ℹ️ INFO EPAR table present in font?
- ℹ️ INFO
EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818
[code: lacks-EPAR]
ℹ️ INFO Show hinting filesize impact.
- ℹ️ INFO
Hinting filesize impact:
ofl/playwritecoguides/PlaywriteCOGuides-Regular.ttf | |
---|---|
Dehinted Size | 349.1kb |
Hinted Size | 349.1kb |
Increase | 24 bytes |
Change | 0.0 % |
ℹ️ INFO Font contains all required tables?
- ℹ️ INFO
This font contains the following optional tables:
- loca
- prep
- GPOS
- GSUB
- gasp
[code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges][1] Family checks
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 1 | 0 | 11 | 75 | 7 | 158 | 0 |
0% | 0% | 0% | 4% | 30% | 3% | 63% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
This comment was marked as outdated.
This comment was marked as outdated.
@vv-monsalve LGTM :) We are just waiting for images! 👌 |
FontBakery reportfontbakery version: 0.13.0a5 Check results[17] PlaywriteCOGuides-Regular.ttf
|
WARN messages | Languages |
---|---|
Some auxiliary glyphs were missing: ſ | de_Latn (German) and fr_Latn (French) |
Some auxiliary glyphs were missing: Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ | fi_Latn (Finnish) |
⚠️ WARN Check the direction of the outermost contour in each glyph
⚠️ WARNThe following glyphs have a counter-clockwise outer contour:
* cnct.cnt_b_z has a counter-clockwise outer contour
* cnct.cnt_b_z has a counter-clockwise outer contour
* cnct.cnt_b_z has a counter-clockwise outer contour
* cnct.cnt_c_z has a counter-clockwise outer contour
* cnct.cnt_c_z has a counter-clockwise outer contour
* cnct.cnt_f_z has a counter-clockwise outer contour
* cnct.cnt_o_n has a counter-clockwise outer contour
* cnct.cnt_o_n has a counter-clockwise outer contour
* cnct.cnt_o_n has a counter-clockwise outer contour
* cnct.cnt_o_z has a counter-clockwise outer contour
* 471 more.
Use -F or --full-lists to disable shortening of long lists.
[code: ccw-outer-contour]⚠️ WARN Do outlines contain any jaggy segments?
⚠️ WARNThe following glyphs have jaggy segments:
* A.cur (U+0041): L<<787.0,175.0>--<830.0,306.0>>/B<<830.0,306.0>-<783.0,226.0>-<732.5,165.5>> = 12.262109763757904
* A.cur.ini: L<<797.0,206.0>--<830.0,306.0>>/B<<830.0,306.0>-<783.0,226.0>-<732.5,165.5>> = 12.171345811249271
* r.mod.ini: L<<239.0,490.0>--<203.0,377.0>>/B<<203.0,377.0>-<228.0,418.0>-<253.0,445.5>> = 13.701954778116432
* r.mod.med: L<<265.0,490.0>--<228.0,377.0>>/B<<228.0,377.0>-<254.0,418.0>-<279.0,445.5>> = 14.250490794068266
[code: found-jaggy-segments]
⚠️ WARN Do outlines contain any semi-vertical or semi-horizontal lines?
⚠️ WARNThe following glyphs have semi-vertical/semi-horizontal lines:
* Wacute (U+1E82): L<<893.0,13.0>--<896.0,938.0>>
* Wacute (U+1E82): L<<948.0,1012.0>--<942.0,78.0>>
* Wcircumflex (U+0174): L<<893.0,13.0>--<896.0,938.0>>
* Wcircumflex (U+0174): L<<948.0,1012.0>--<942.0,78.0>>
* Wdieresis (U+1E84): L<<893.0,13.0>--<896.0,938.0>>
* Wdieresis (U+1E84): L<<948.0,1012.0>--<942.0,78.0>>
* Wgrave (U+1E80): L<<893.0,13.0>--<896.0,938.0>>
* Wgrave (U+1E80): L<<948.0,1012.0>--<942.0,78.0>>
* w.mod.fin: L<<104.0,11.0>--<102.0,489.0>>
* w.mod.ini: L<<104.0,11.0>--<102.0,489.0>>
* 6 more.
Use -F or --full-lists to disable shortening of long lists.
[code: found-semi-vertical]⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
⚠️ WARNThis font file does not have a 'meta' table.
[code: lacks-meta-table]
⚠️ WARN Check font follows the Google Fonts vertical metric schema
⚠️ WARNWe recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.977x (1977)
[code: bad-hhea-range]
ℹ️ INFO EPAR table present in font?
- ℹ️ INFO
EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818
[code: lacks-EPAR]
ℹ️ INFO Show hinting filesize impact.
- ℹ️ INFO
Hinting filesize impact:
ofl/playwritecoguides/PlaywriteCOGuides-Regular.ttf | |
---|---|
Dehinted Size | 349.1kb |
Hinted Size | 349.1kb |
Increase | 24 bytes |
Change | 0.0 % |
ℹ️ INFO Font contains all required tables?
- ℹ️ INFO
This font contains the following optional tables:
- loca
- prep
- GPOS
- GSUB
- gasp
[code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges][1] Family checks
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 0 | 11 | 75 | 7 | 159 | 0 |
0% | 0% | 0% | 4% | 30% | 3% | 63% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
FontBakery reportfontbakery version: 0.13.0a5 Check results[18] PlaywriteCOGuides-Regular.ttf🔥 FAIL METADATA.pb should contain at least "menu" and "latin" subsets.
|
WARN messages | Languages |
---|---|
Some auxiliary glyphs were missing: ſ | de_Latn (German) and fr_Latn (French) |
Some auxiliary glyphs were missing: Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ | fi_Latn (Finnish) |
⚠️ WARN Check the direction of the outermost contour in each glyph
⚠️ WARNThe following glyphs have a counter-clockwise outer contour:
* cnct.cnt_b_z has a counter-clockwise outer contour
* cnct.cnt_b_z has a counter-clockwise outer contour
* cnct.cnt_b_z has a counter-clockwise outer contour
* cnct.cnt_c_z has a counter-clockwise outer contour
* cnct.cnt_c_z has a counter-clockwise outer contour
* cnct.cnt_f_z has a counter-clockwise outer contour
* cnct.cnt_o_n has a counter-clockwise outer contour
* cnct.cnt_o_n has a counter-clockwise outer contour
* cnct.cnt_o_n has a counter-clockwise outer contour
* cnct.cnt_o_z has a counter-clockwise outer contour
* 471 more.
Use -F or --full-lists to disable shortening of long lists.
[code: ccw-outer-contour]⚠️ WARN Do outlines contain any jaggy segments?
⚠️ WARNThe following glyphs have jaggy segments:
* A.cur (U+0041): L<<787.0,175.0>--<830.0,306.0>>/B<<830.0,306.0>-<783.0,226.0>-<732.5,165.5>> = 12.262109763757904
* A.cur.ini: L<<797.0,206.0>--<830.0,306.0>>/B<<830.0,306.0>-<783.0,226.0>-<732.5,165.5>> = 12.171345811249271
* r.mod.ini: L<<239.0,490.0>--<203.0,377.0>>/B<<203.0,377.0>-<228.0,418.0>-<253.0,445.5>> = 13.701954778116432
* r.mod.med: L<<265.0,490.0>--<228.0,377.0>>/B<<228.0,377.0>-<254.0,418.0>-<279.0,445.5>> = 14.250490794068266
[code: found-jaggy-segments]
⚠️ WARN Do outlines contain any semi-vertical or semi-horizontal lines?
⚠️ WARNThe following glyphs have semi-vertical/semi-horizontal lines:
* Wacute (U+1E82): L<<893.0,13.0>--<896.0,938.0>>
* Wacute (U+1E82): L<<948.0,1012.0>--<942.0,78.0>>
* Wcircumflex (U+0174): L<<893.0,13.0>--<896.0,938.0>>
* Wcircumflex (U+0174): L<<948.0,1012.0>--<942.0,78.0>>
* Wdieresis (U+1E84): L<<893.0,13.0>--<896.0,938.0>>
* Wdieresis (U+1E84): L<<948.0,1012.0>--<942.0,78.0>>
* Wgrave (U+1E80): L<<893.0,13.0>--<896.0,938.0>>
* Wgrave (U+1E80): L<<948.0,1012.0>--<942.0,78.0>>
* w.mod.fin: L<<104.0,11.0>--<102.0,489.0>>
* w.mod.ini: L<<104.0,11.0>--<102.0,489.0>>
* 6 more.
Use -F or --full-lists to disable shortening of long lists.
[code: found-semi-vertical]⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
⚠️ WARNThis font file does not have a 'meta' table.
[code: lacks-meta-table]
⚠️ WARN Check font follows the Google Fonts vertical metric schema
⚠️ WARNWe recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.977x (1977)
[code: bad-hhea-range]
ℹ️ INFO EPAR table present in font?
- ℹ️ INFO
EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818
[code: lacks-EPAR]
ℹ️ INFO Show hinting filesize impact.
- ℹ️ INFO
Hinting filesize impact:
ofl/playwritecoguides/PlaywriteCOGuides-Regular.ttf | |
---|---|
Dehinted Size | 349.1kb |
Hinted Size | 349.1kb |
Increase | 24 bytes |
Change | 0.0 % |
ℹ️ INFO Font contains all required tables?
- ℹ️ INFO
This font contains the following optional tables:
- loca
- prep
- GPOS
- GSUB
- gasp
[code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges][1] Family checks
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 1 | 11 | 75 | 7 | 158 | 0 |
0% | 0% | 0% | 4% | 30% | 3% | 63% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
This failure is expected, and we need to accept it. For the Playwrite Project, the decision was made to use a strategy that only includes the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Taken from the upstream repo https://github.com/TypeTogether/Playwrite at commit TypeTogether/Playwrite@dc7ceab.
Resolves #8535
PR Checklist:
minisite_url
definition in the METADATA.pb file for commissioned projectstags
are added for NEW FONTSprimary_script
definition in the METADATA.pb file for all projects that have a primary non-Latin based language support targetsubsets
definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsetschinese-hongkong
,chinese-simplified
,chinese-traditional
,korean
,japanese
.