Fix the corpus value validation for InRegexp.
#1672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
The function `RegexpDFA::DFAPathToString()` that is used in the corpus value validation wasn't checking that the DFA path is consistent with the DFA, i.e., that the states along the path are really the ones appearing in the DFA if we follow the path. It also wasn't checking that the path reaches the end state. I also cleaned up the code a bit and added a few general improvements. PiperOrigin-RevId: 755663271
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the corpus value validation for
InRegexp.The function
RegexpDFA::DFAPathToString()that is used in the corpus valuevalidation wasn't checking that the DFA path is consistent with the DFA,
i.e., that the states along the path are really the ones appearing in the DFA
if we follow the path. It also wasn't checking that the path reaches the end
state.
I also cleaned up the code a bit and added a few general improvements.