-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement Compute Security Policies Crawler #308
feat: Implement Compute Security Policies Crawler #308
Conversation
…trap script. Add compute securit config in example config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with two minor nits. Once you fix it, we can push the commit. Thanks again for implementing it.
except Exception: | ||
logging.info("Failed to enumerate compute security policies in the %s", project_name) | ||
logging.info(sys.exc_info()) | ||
return security_policies_list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls add new line at the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed this with new commit
# update default rule to deny all traffic (default rule has priority 2147483647) | ||
gcloud compute security-policies rules update 2147483647 \ | ||
--security-policy test-security-policy \ | ||
--action "deny-404" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New line pls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed this with new commit
Description
Issue #247 . Added support for Compute/securitypolicies resource
Changes Made
cloud_security_policies_crawler.py
Testing
App ran successfully during local testing