Add Python bindings to annotating_importer.
#139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
virajbshah
commented
Jul 17, 2024
virajbshah
commented
- Add bindings to the driver function.
- Add a small python script that exposes the binding for use.
ondrasej
requested changes
Sep 2, 2024
* Add bindings to the driver function. * Add a small python script that exposes the binding for use.
virajbshah
force-pushed
the
annotating-importer-py
branch
from
08345f7
to
31fb348
Compare
ondrasej
reviewed
Sep 13, 2024
Comment on lines
+75
to
+79
| except status.StatusNotOk: | ||
| logging.exception( | ||
| 'LLVM triple "%s" is not known or supported.', _LLVM_TRIPLE.value | ||
| ) | ||
| exit(1) |
There was a problem hiding this comment.
Optional: Just letting the exception bubble up uncaught would have pretty much the same effect.
ondrasej
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.