-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python bindings to annotating_importer
.
#139
Conversation
virajbshah
commented
Jul 17, 2024
- Add bindings to the driver function.
- Add a small python script that exposes the binding for use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, I have just a few minor comments.
* Add bindings to the driver function. * Add a small python script that exposes the binding for use.
08345f7
to
31fb348
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor comments, otherwise it looks good.
except status.StatusNotOk: | ||
logging.exception( | ||
'LLVM triple "%s" is not known or supported.', _LLVM_TRIPLE.value | ||
) | ||
exit(1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional: Just letting the exception bubble up uncaught would have pretty much the same effect.