-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python bindings for exegesis_benchmark #176
Merged
boomanaiden154
merged 8 commits into
main
from
users/boomanaiden154/benchmark-python-bindings
Sep 2, 2024
Merged
Add python bindings for exegesis_benchmark #176
boomanaiden154
merged 8 commits into
main
from
users/boomanaiden154/benchmark-python-bindings
Sep 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch refactors the majority of the functionality in the exegesis_benchmark binary into a library. This allows reuse in other parts of the code base, particularly beam pipelines once python bindings have been written.
This patch adds unit tests for the exegesis benchmark library.
This patch adds functionality in exegesis_benchmark_lib to directly create a benchmark configuration (BenchmarkCode) from annotations (BlockAnnotations). This is intended to be used primarily from the python bindings, where we get annotations directly from the annotator and then need to run benchmarking directly on that rather than serializing to JSON.
This patch adds python bindings to exegesis_benchmark. This allows for benchmarking to be performed from Python, primarily in Beam pipelines.
Base automatically changed from
users/boomanaiden154/benchmark-from-annotated-block
to
main
August 12, 2024 06:09
ondrasej
requested changes
Aug 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First batch of comments. I still need to take a look at the _lib.cc
and _lib_test.cc
.
ondrasej
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds python bindings to exegesis_benchmark. This allows for benchmarking to be performed from Python, primarily in Beam pipelines.