Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python bindings for exegesis_benchmark #176

Merged
merged 8 commits into from
Sep 2, 2024

Conversation

boomanaiden154
Copy link
Collaborator

This patch adds python bindings to exegesis_benchmark. This allows for benchmarking to be performed from Python, primarily in Beam pipelines.

boomanaiden154 and others added 4 commits August 11, 2024 08:13
This patch refactors the majority of the functionality in the
exegesis_benchmark binary into a library. This allows reuse in other
parts of the code base, particularly beam pipelines once python bindings
have been written.
This patch adds unit tests for the exegesis benchmark library.
This patch adds functionality in exegesis_benchmark_lib to directly
create a benchmark configuration (BenchmarkCode) from annotations
(BlockAnnotations). This is intended to be used primarily from the
python bindings, where we get annotations directly from the annotator
and then need to run benchmarking directly on that rather than
serializing to JSON.
This patch adds python bindings to exegesis_benchmark. This allows for
benchmarking to be performed from Python, primarily in Beam pipelines.
Base automatically changed from users/boomanaiden154/benchmark-from-annotated-block to main August 12, 2024 06:09
Copy link
Collaborator

@ondrasej ondrasej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First batch of comments. I still need to take a look at the _lib.cc and _lib_test.cc.

gematria/datasets/python/exegesis_benchmark.cc Outdated Show resolved Hide resolved
gematria/datasets/python/exegesis_benchmark.cc Outdated Show resolved Hide resolved
gematria/datasets/python/exegesis_benchmark.cc Outdated Show resolved Hide resolved
gematria/datasets/exegesis_benchmark_lib.h Outdated Show resolved Hide resolved
gematria/datasets/exegesis_benchmark_lib.cc Outdated Show resolved Hide resolved
@boomanaiden154 boomanaiden154 marked this pull request as ready for review August 26, 2024 21:25
@boomanaiden154 boomanaiden154 merged commit 4e495b5 into main Sep 2, 2024
9 checks passed
@boomanaiden154 boomanaiden154 deleted the users/boomanaiden154/benchmark-python-bindings branch September 2, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants