Refactor: Improve model classes and remove redundant parameters #91
+23
−39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two significant code quality improvements to
gemma/model.pyto enhance maintainability and API clarity. Fix #901. Refactor
LinearandEmbeddingwith a Base ClassQuantizedWeightbase class has been created to abstract the shared logic for handling quantized weights. TheLinearandEmbeddingclasses now inherit from it.2. Remove Redundant
kv_write_indicesParameterkv_write_indicesparameter in theGemmaForCausalLM.forwardmethod signature is removed.input_positionsand its passed value was never used. Removing it cleans up the API and prevents confusion for developers.These changes make the codebase more robust and easier to understand without altering functionality.