Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plain text to multimodal prompting guide #400

Closed
wants to merge 4 commits into from

Conversation

pcoet
Copy link
Contributor

@pcoet pcoet commented May 6, 2024

Description of the change

Update multimodal prompting guide to include plain text support.

Motivation

Type of change

Choose one: (Bug fix | Feature request | Documentation | Other)

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

@pcoet pcoet requested a review from a team as a code owner May 6, 2024 03:54
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:documentation Update docs labels May 6, 2024
@@ -65,10 +65,9 @@
},
Copy link
Member

@markmcd markmcd May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this wording sound less strict?

they are subject to the following limitations and requirements

It's not a strict requirement that plain text inputs adhere to one of these formats, since they don't map to an encoding like other media.

We should also recommend that users specify the MIME type manually if it isn't in this list. In this cookbook recipe I gave an example with a C++ file because that's not detected as plain-text, but it really is, so users can specify it.


Reply via ReviewNB

@pcoet
Copy link
Contributor Author

pcoet commented May 6, 2024

Closing this and opening a new PR against the io-features branch: #401

@pcoet pcoet closed this May 6, 2024
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants