add same kind of validation used on kafka

google · May 28, 2024 · ca2c5a2 · ca2c5a2
1 parent 3cd7cf1
commit ca2c5a2
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/pubsub/rabbitpubsub/rabbit.go b/pubsub/rabbitpubsub/rabbit.go
@@ -125,14 +125,13 @@ func (o *URLOpener) OpenSubscriptionURL(ctx context.Context, u *url.URL) (*pubsu
 	for param, value := range u.Query() {
 		switch param {
 		case "prefetch_count":
-			if len(value) == 0 {
+			if len(value) != 1 || len(value[0]) == 0 {
 				return nil, fmt.Errorf("open subscription %v: invalid query parameter %q", u, param)
 			}
-			count := value[0]
 
-			prefetchCount, err := strconv.Atoi(count)
+			prefetchCount, err := strconv.Atoi(value[0])
 			if err != nil {
-				return nil, fmt.Errorf("open subscription %v: invalid query parameter %q", u, count)
+				return nil, fmt.Errorf("open subscription %v: invalid query parameter %q: %w", u, param, err)
 			}
 
 			opts.PrefetchCount = &prefetchCount