Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtimevar/constantvar: Add support for reading the constantvar from an environment variable #3318

Merged
merged 1 commit into from
Sep 16, 2023

Conversation

vangent
Copy link
Contributor

@vangent vangent commented Sep 16, 2023

Fixes #3316

@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Merging #3318 (3e5fa73) into master (16a4757) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3318      +/-   ##
==========================================
- Coverage   77.47%   77.47%   -0.01%     
==========================================
  Files         104      104              
  Lines       13923    13933      +10     
==========================================
+ Hits        10787    10794       +7     
- Misses       2376     2378       +2     
- Partials      760      761       +1     
Files Changed Coverage Δ
runtimevar/constantvar/constantvar.go 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@vangent vangent merged commit db7e808 into google:master Sep 16, 2023
@vangent vangent deleted the rtvenv branch September 16, 2023 17:25
ybourgery pushed a commit to Simprints/go-cloud that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runtimevar: support env url
1 participant