secrets/awskms: update the example for the AWS ARN use case #3320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please run internal/website/gatherexamples/run.sh > internal/website/data/examples.json and add the commit. |
…h > internal/website/data/examples.json`;
Codecov Report
@@ Coverage Diff @@
## master #3320 +/- ##
==========================================
+ Coverage 77.45% 77.48% +0.02%
==========================================
Files 104 104
Lines 13933 13933
==========================================
+ Hits 10792 10796 +4
+ Misses 2380 2377 -3
+ Partials 761 760 -1 |
|
Thanks for the fix! |
ybourgery
pushed a commit
to Simprints/go-cloud
that referenced
this pull request
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title.
AWS ARN can't be parsed by
url.Parse()directly, because there are couple:in it. (e.g.,"awskms://arn:aws:kms:us-east-1:932528106278:key/8be0dcc5-da0a-4164-a99f-649015e344b5?region=us-east-1")Then I fell into that trap💀, so here is a PR to avoid further victims.
The issue has been solved, but the use case isn't updated.