feat/docstore in query operation #3358
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! I don't think you can generate the replay files. I'll either have to figure out how to get access to this PR so I can run it locally and generate them, then update the PR, or clone the PR entirely. It might take a bit as this is a larger effort than I have time for right now. |
|
The code changes look fine to me, so I cloned your PR and updated the various .replay files (#3372). |
|
(The drivertest you added passes for all the providers, so LGTM!) |
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #3352
This PR updates the docstore to allow in/not-in queries.
This isn't yet merge-able, I need some assistance to get this into shape.
Test replay data does not exist for this type of query, so tests that rely on that don't work currently. Am I able to generate those myself somehow?
I haven't tested the dynamodb changes at all.
I updated the local mongodb test, but haven't tried this against cosmo.
I tested firstore functionality with this snipit, and it seems to function, but the real tests continue to fail due to the missing replays. https://gist.github.com/coryschwartz/80c37f15f58ddf0d8c979073f30d6ccf