Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docstore/driver: update Filter.Op comments for new in/not-in operators #3376

Merged
merged 1 commit into from
Jan 14, 2024
Merged

docstore/driver: update Filter.Op comments for new in/not-in operators #3376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docstore/driver/driver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ type Query struct {
// TODO(#1762): support comparison of other types.
type Filter struct {
FieldPath []string // the field path to filter
Op string // the operation, supports =, >, >=, <, <=
Op string // the operation, supports `=`, `>`, `>=`, `<`, `<=`, `in`, `not-in`
Value interface{} // the value to compare using the operation
}

Expand Down
Loading