-
Notifications
You must be signed in to change notification settings - Fork 591
crane: Add timestamp to flatten layer #2117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crane: Add timestamp to flatten layer #2117
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hi! Created this PR for visibility since the previous PR was labeled as stale. @jonjohnsonjr @Subserial @imjasonh @brandonmichigangithub Mind reviewing this so these changes can be merged (much appreciated)? |
@brandonmichigangithub The lint failure is unrelated to my changes. Do you mind merging this PR? Thanks! |
Can you edit the lint ignore flag such that you can ignore this failure? |
Actually, can you rebase this pull request? This issue should be fixed with #2137 |
@brandonmichigangithub Hello! I updated the branch to incorporate the fix but need maintainer approval to run the workflow. |
Head branch was pushed to by a user without write access
97ac5a8
to
e656953
Compare
@brandonmichigangithub Hello! Bumping the previous message.
|
@brandonmichigangithub Do you mind merging in my PR 😄 ? I see CI has passed. |
Fixes #2115, which was reopened from #1974.
After using crane flatten, the new layer does not have created time set. This will set the created time to the current time.
Tested: