Remove dependency on cpp-jsonnet submodule from C bindings #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows us to build libgojsonnet from tarball downloaded from GitHub releases.
1 similar comment
|
We can probably go forward with this, but I don't like that we can now accidentally diverge from the original headers without noticing it. Maybe we could keep a copy of the header in the repo and use it for compiling libgojsonnet. We could then check if it's the same as in cpp-jsonnet in tests.sh (which depends on cpp-jsonnet anyway). Let me think about this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows us to build libgojsonnet from tarball downloaded from
GitHub releases.