Optimize runtime complexity of linter when passing in multiple snippets #725
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #557 .
Instead of calculating all roots at the start we delay that when evaluating each individual snippet.
The roots data structure is populated with all nodes of all imported jsonnet snippets, so we utilize that also in the importFunc where we try to resolve imports from the list of roots to avoid doing duplicate imports.
However this is a best effort only, as the mechanism is not smart, but is just able to resolve imports in the same path. This could be further improved, but for the test cases that is already sufficient, as all of them are in the same directory.
With this fix, the multiple tests run in around 0.23s compared to 9s before.