Fix linter issues

client/pcr.go

@@ -26,7 +26,7 @@ const (
 // CertifyHashAlgTpm is the hard-coded algorithm used in certify PCRs.
 const CertifyHashAlgTpm = tpm2.AlgSHA256
 
-func min(a, b int) int {
+func minimum(a, b int) int {
 	if a < b {
 		return a
 	}
@@ -66,7 +66,7 @@ func ReadPCRs(rw io.ReadWriter, sel tpm2.PCRSelection) (*pb.PCRs, error) {
 	}
 
 	for i := 0; i < len(sel.PCRs); i += 8 {
-		end := min(i+8, len(sel.PCRs))
+		end := minimum(i+8, len(sel.PCRs))
 		pcrSel := tpm2.PCRSelection{
 			Hash: sel.Hash,
 			PCRs: sel.PCRs[i:end],

internal/models/token_options.go

@@ -27,14 +27,17 @@ type ContainerImageSignatures struct {
 	KeyIDs []string `json:"key_ids"`
 }
 
+// HasAWSPrincipalTagOptions returns true if PrincipalTagOptions is not nil.
 func (t TokenOptions) HasAWSPrincipalTagOptions() bool {
 	return t.PrincipalTagOptions != nil
 }
 
+// HasAllowedPrincipalTags returns true if AllowedPrincipalTags is not nil.
 func (a AWSPrincipalTagsOptions) HasAllowedPrincipalTags() bool {
 	return a.AllowedPrincipalTags != nil
 }
 
+// HasContainerImageSignatures returns true if ContainerImageSignatures is not nil.
 func (a AllowedPrincipalTags) HasContainerImageSignatures() bool {
 	return a.ContainerImageSignatures != nil
 }

internal/pcrs.go

@@ -16,13 +16,13 @@ import (
 const minPCRIndex = uint32(0)
 
 func maxPCRIndex(p *pb.PCRs) uint32 {
-	max := minPCRIndex
+	high := minPCRIndex
 	for idx := range p.GetPcrs() {
-		if idx > max {
-			max = idx
+		if idx > high {
+			high = idx
 		}
 	}
-	return max
+	return high
 }
 
 // FormatPCRs writes a multiline representation of the PCR values to w.

launcher/teeserver/tee_server.go

@@ -78,7 +78,7 @@ func (a *attestHandler) getToken(w http.ResponseWriter, r *http.Request) {
 
 		if err != nil {
 			err = fmt.Errorf("failed to get the token")
-			a.logAndWriteHttpError(w, http.StatusNotFound, err)
+			a.logAndWriteHTTPError(w, http.StatusNotFound, err)
 			return
 		}
 		w.WriteHeader(http.StatusOK)
@@ -91,21 +91,21 @@ func (a *attestHandler) getToken(w http.ResponseWriter, r *http.Request) {
 
 		err := decoder.Decode(&tokenOptions)
 		if err != nil {
-			a.logAndWriteHttpError(w, http.StatusBadRequest, err)
+			a.logAndWriteHTTPError(w, http.StatusBadRequest, err)
 			return
 		}
 
 		err = validateTokenOptions(tokenOptions)
 		if err != nil {
-			a.logAndWriteHttpError(w, http.StatusBadRequest, err)
+			a.logAndWriteHTTPError(w, http.StatusBadRequest, err)
 			return
 		}
 
 		tok, err := a.attestAgent.Attest(a.ctx, agent.AttestAgentOpts{
 			TokenOptions: &tokenOptions,
 		})
 		if err != nil {
-			a.logAndWriteHttpError(w, http.StatusBadRequest, err)
+			a.logAndWriteHTTPError(w, http.StatusBadRequest, err)
 			return
 		}
 
@@ -115,11 +115,11 @@ func (a *attestHandler) getToken(w http.ResponseWriter, r *http.Request) {
 	default:
 		// TODO: add an url pointing to the REST API document
 		err := fmt.Errorf("TEE server recieved an invalid HTTP method: %s", r.Method)
-		a.logAndWriteHttpError(w, http.StatusBadRequest, err)
+		a.logAndWriteHTTPError(w, http.StatusBadRequest, err)
 	}
 }
 
-func (a *attestHandler) logAndWriteHttpError(w http.ResponseWriter, statusCode int, err error) {
+func (a *attestHandler) logAndWriteHTTPError(w http.ResponseWriter, statusCode int, err error) {
 	a.logger.Error(err.Error())
 	w.WriteHeader(statusCode)
 	w.Write([]byte(err.Error()))