Add test coverage for IPC server #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKrstic
force-pushed
the
servertest
branch
2 times, most recently
from
8dbb13b to
48e4528
Compare
JoshuaKrstic
commented
Nov 13, 2023
JoshuaKrstic
force-pushed
the
servertest
branch
10 times, most recently
from
4b6ebe7 to
e268d10
Compare
yawangwang
reviewed
Nov 16, 2023
yawangwang
approved these changes
Nov 16, 2023
JoshuaKrstic
force-pushed
the
servertest
branch
5 times, most recently
from
5a39acf to
b313fcd
Compare
Add image test Move tests to different regions to avoid region N2D caps Use new tokentype field in VerifyAttestation requets
JoshuaKrstic
force-pushed
the
servertest
branch
from
b313fcd to
35d81ba
Compare
yawangwang
reviewed
Nov 20, 2023
yawangwang
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unit tests for failure cases and happy path
Added image test for happy path, token is required to validate
TODO(future) - Add tests with invalid inputs validating we get the errors we expect