Remove tail() from logging since it's broken anyway #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
requested changes
Mar 5, 2024
|
The broken test is a known issue with the google auth library... |
Co-authored-by: Kevin Moore <[email protected]>
Co-authored-by: Kevin Moore <[email protected]>
|
I reserve the right to bump this down to a "dot" release. Removing features that don't work is not a big breaking change in my book. 😄 |
|
Technically it is a breaking change. Maybe there's a library that wraps logging API and uses this method internally, no matter if it doesn't work. Of course, it's up to you to decide whether this is a breaking change. I followed a semver guideline and a method removal is a breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #407