Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data collection] Clicking "x" in top left corner discards data without prompting user #2635

Closed
gino-m opened this issue Aug 12, 2024 · 11 comments · Fixed by #3024
Closed

[Data collection] Clicking "x" in top left corner discards data without prompting user #2635

gino-m opened this issue Aug 12, 2024 · 11 comments · Fixed by #3024
Assignees
Labels
type: bug Something isn't working
Milestone

Comments

@gino-m
Copy link
Collaborator

gino-m commented Aug 12, 2024

User should be prompted whether they want to lose/discard the data they've collected so far:

Screenshot_20240812_153956

@amegantz @rawbzz for input.

@gino-m gino-m added type: bug Something isn't working ux needed Product input from PM/UX needed labels Aug 12, 2024
@gino-m gino-m added this to the GA release milestone Aug 12, 2024
@gino-m gino-m added this to Ground Aug 12, 2024
@amegantz
Copy link

image
If you close this job, any data you’ve collected so far will be discarded. Are you sure you want to close this job?

@gino-m
Copy link
Collaborator Author

gino-m commented Aug 19, 2024

image If you close this job, any data you’ve collected so far will be discarded. Are you sure you want to close this job?

The term "job" is already taken - it refer the full set of tasks to be done for a set of LOIs. Taken literally, this text would make it seem as if data for other LOIs will also be lost. How can we disambiguate?

@amegantz
Copy link

To clarify, what does tapping the "X" do? Cancel the job or just this task?

@gino-m
Copy link
Collaborator Author

gino-m commented Aug 20, 2024

To clarify, what does tapping the "X" do? Cancel the job or just this task?

It stops the data collection flowm discarding data collected so for. You can't "cancel" as task, per se, but you can tap "Skip" to jump to the next if the task is optional.

@amegantz
Copy link

Is this more accurate?
image
Close task?
If you close this task, any data you’ve collected for this task will be discarded.
[Cancel] [Confirm]

@gino-m
Copy link
Collaborator Author

gino-m commented Aug 28, 2024

@amegantz The "x" stops the whole data collection flow; data from this and other tasks (i.e., the submission) is lost. Perhaps something along the lines of "Exit/quit/abort data collection?" ... "If you leave without submitting data collected so far will be lost"?

@amegantz
Copy link

image
How about this?

@gino-m
Copy link
Collaborator Author

gino-m commented Aug 29, 2024

Lg! On nit: perhaps we should remove "any" so that they don't think this includes previous unsynced submissions?

@amegantz
Copy link

amegantz commented Sep 9, 2024

image

Stop collecting data?
If you exit before submitting data, data you’ve collected so far will be discarded.
[Cancel] [Confirm]

@gino-m
Copy link
Collaborator Author

gino-m commented Sep 12, 2024

"Data collected so far" might mean "since all time". What about: "If you stop now, unsubmitted data will be lost"?

@amegantz
Copy link

image
Stop collecting data?
If you exit, data you haven’t submitted yet will be discarded.
[Cancel] [Confirm]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants