Show a warning dialog when attempting to close data collection screen #3024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `ConfirmationDialog` preview. * Update `ConfirmationDialog` to track dialog state internally. * Refactor `showConfirmationDialog` to use new `ConfirmationDialog` implementation. * Remove unnecessary mutable state. * Update string resource names to match their purpose.
- Replaced the default navigation action with a custom warning dialog. - Added a new function `showConfirmationDialog` to display the exit warning dialog. - Modified `onBack` to trigger the warning dialog when appropriate. - Moved clearDraft() call to onConfirm action.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3024 +/- ##
============================================
+ Coverage 63.61% 63.65% +0.04%
- Complexity 1272 1274 +2
============================================
Files 271 271
Lines 6572 6593 +21
Branches 930 931 +1
============================================
+ Hits 4181 4197 +16
- Misses 1789 1794 +5
Partials 602 602
|
app/src/main/java/com/google/android/ground/ui/compose/ConfirmationDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/google/android/ground/ui/compose/ConfirmationDialog.kt
Show resolved
Hide resolved
anandwana001
approved these changes
Jan 30, 2025
|
@gino-m Who should we tag for validating the non-english translation strings? |
jo-spek
requested changes
Jan 30, 2025
There was a problem hiding this comment.
Minor change to French and Spanish, with kind help of @PilarValbuena
|
Thank you @jo-spek and @PilarValbuena |
|
@jo-spek Can you please re-stamp the PR? |
jo-spek
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2635
Adds a new warning dialog before discarding the in-progress data collection screen.
data.collection.confirmation.dialog.mp4
@anandwana001 PTAL?