Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a snackbar when draft is restored #2666

Merged
merged 10 commits into from
Sep 5, 2024

Conversation

shobhitagarwal1612
Copy link
Member

Fixes #2303

draft-restored-snackbar.webm

@gino-m PTAL?

Copy link
Collaborator

@gino-m gino-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @amegantz for UXW approval

ground/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@gino-m gino-m requested review from amegantz and gino-m August 19, 2024 13:34
@shobhitagarwal1612
Copy link
Member Author

/gcbrun

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 5.26316% with 18 lines in your changes missing coverage. Please review.

Project coverage is 60.97%. Comparing base (446cef4) to head (4171335).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...oogle/android/ground/ui/home/HomeScreenFragment.kt 0.00% 13 Missing and 1 partial ⚠️
...ogle/android/ground/ui/home/HomeScreenViewModel.kt 20.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2666      +/-   ##
============================================
- Coverage     61.02%   60.97%   -0.06%     
  Complexity     1162     1162              
============================================
  Files           263      263              
  Lines          6050     6055       +5     
  Branches        827      828       +1     
============================================
  Hits           3692     3692              
- Misses         1890     1895       +5     
  Partials        468      468              
Files with missing lines Coverage Δ
...ogle/android/ground/ui/home/HomeScreenViewModel.kt 83.33% <20.00%> (+13.33%) ⬆️
...oogle/android/ground/ui/home/HomeScreenFragment.kt 48.91% <0.00%> (-8.05%) ⬇️

@amegantz
Copy link

"Unsynced data restored"?

@gino-m
Copy link
Collaborator

gino-m commented Aug 20, 2024

"Unsynced data restored"?

It's not that the data wasn't synced, it simply wasn't saved locally yet.

@amegantz
Copy link

Sounds like "Unsaved data restored" should work?

@shobhitagarwal1612
Copy link
Member Author

Updated the text string. @gino-m PTAL

@shobhitagarwal1612
Copy link
Member Author

@gino-m Gentle ping!

@shobhitagarwal1612 shobhitagarwal1612 merged commit c83bca4 into master Sep 5, 2024
4 checks passed
@shobhitagarwal1612 shobhitagarwal1612 deleted the ashobhit/2303/draft-snackbar branch September 5, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Data collection] Show message when draft is restored
3 participants