[Photo crash] Don't attempt to rotate the image if orientation is undefined in exif metadata #2694
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2688
From the error stacktrace, we can identify that the crash happened as we haven't handled
ExifInterface.ORIENTATION_UNDEFINED
when attempting to force rotate an image.As per https://stackoverflow.com/a/28024859, some devices don't write the device's orientation to the EXIF metadata and directly rotate the image pixels.
So, this PR proposes to ignore the rotating if this is unset.
@sufyanAbbasi @gino-m PTAL?