Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multiple choice questions] Make "other" text required #2870

Merged
merged 6 commits into from
Nov 27, 2024

Conversation

shobhitagarwal1612
Copy link
Member

Fixes #2833

Disables the previous/next buttons if the task is required and user has selected other option but hasn't filled the text.

Verified by running the app locally and via unit tests

@gino-m PTAL?

Copy link

codecov bot commented Nov 24, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.19%. Comparing base (ca9e4bd) to head (a090df9).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...asks/multiplechoice/MultipleChoiceTaskViewModel.kt 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2870   +/-   ##
=========================================
  Coverage     61.19%   61.19%           
- Complexity     1177     1182    +5     
=========================================
  Files           266      266           
  Lines          6345     6345           
  Branches        906      904    -2     
=========================================
  Hits           3883     3883           
  Misses         1933     1933           
  Partials        529      529           
Files with missing lines Coverage Δ
...asks/multiplechoice/MultipleChoiceTaskViewModel.kt 92.64% <88.88%> (ø)

@shobhitagarwal1612
Copy link
Member Author

@gino-m PTAL

Copy link
Collaborator

@gino-m gino-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much clearer, thank you! 🙏

@shobhitagarwal1612 shobhitagarwal1612 merged commit dccdd41 into master Nov 27, 2024
4 checks passed
@shobhitagarwal1612 shobhitagarwal1612 deleted the ashobhit/2833/other branch November 27, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Multiple choice questions] "Other" text not required on "Required" questions
3 participants