-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data collection] Restore position to last active task when restoring from draft #2871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2871 +/- ##
============================================
+ Coverage 62.64% 62.67% +0.02%
- Complexity 1206 1209 +3
============================================
Files 269 269
Lines 6366 6373 +7
Branches 878 879 +1
============================================
+ Hits 3988 3994 +6
- Misses 1829 1832 +3
+ Partials 549 547 -2
|
gino-m
requested changes
Nov 26, 2024
gino-m
approved these changes
Dec 3, 2024
gino-m
requested changes
Dec 3, 2024
ground/src/main/java/com/google/android/ground/persistence/local/room/LocalDatabase.kt
Show resolved
Hide resolved
# Conflicts: # ground/src/main/java/com/google/android/ground/ui/home/HomeScreenFragment.kt # ground/src/main/java/com/google/android/ground/ui/home/mapcontainer/HomeScreenMapContainerFragment.kt # ground/src/test/java/com/google/android/ground/ui/datacollection/DataCollectionFragmentTest.kt
gino-m
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2832
Reuses
currentTaskId
mechanism to set the initial task position when restoring from draft.draft-position.webm
@sufyanAbbasi there is some weirdness with task sequence when moving to previous task from restored position. Do you have any ideas?
@sufyanAbbasi @gino-m PTAL?