Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor ktdoc and code cleanup ahead of #2840 #2874

Merged
merged 6 commits into from
Nov 26, 2024
Merged

Conversation

gino-m
Copy link
Collaborator

@gino-m gino-m commented Nov 26, 2024

Towards #2840

@gino-m gino-m merged commit a4ac43e into master Nov 26, 2024
2 checks passed
@gino-m gino-m deleted the gino-m/2840/minor-cleanup branch November 26, 2024 20:21
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.19%. Comparing base (ca9e4bd) to head (64b26a3).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ndroid/ground/model/mutation/SubmissionMutation.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2874   +/-   ##
=========================================
  Coverage     61.19%   61.19%           
- Complexity     1177     1178    +1     
=========================================
  Files           266      266           
  Lines          6345     6345           
  Branches        906      905    -1     
=========================================
  Hits           3883     3883           
  Misses         1933     1933           
  Partials        529      529           
Files with missing lines Coverage Δ
...e/local/room/stores/RoomLocationOfInterestStore.kt 78.94% <ø> (ø)
...droid/ground/persistence/sync/MediaUploadWorker.kt 75.43% <100.00%> (+1.30%) ⬆️
...le/android/ground/repository/MutationRepository.kt 84.61% <100.00%> (ø)
...ogle/android/ground/ui/home/HomeScreenViewModel.kt 80.70% <ø> (ø)
...ndroid/ground/model/mutation/SubmissionMutation.kt 86.36% <0.00%> (-4.12%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants