Mark other_selected if Other selected #2875
Merged
+32
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think we need the other variable as mentioned here Please let me know if I am missing anything here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2875 +/- ##
=========================================
Coverage 61.19% 61.20%
Complexity 1183 1183
=========================================
Files 266 266
Lines 6345 6346 +1
Branches 903 903
=========================================
+ Hits 3883 3884 +1
Misses 1933 1933
Partials 529 529
|
shobhitagarwal1612
requested changes
Nov 27, 2024
.../google/android/ground/ui/datacollection/tasks/multiplechoice/MultipleChoiceTaskViewModel.kt
Outdated
Show resolved
Hide resolved
.../main/java/com/google/android/ground/persistence/remote/firebase/protobuf/ModelToProtoExt.kt
Outdated
Show resolved
Hide resolved
shobhitagarwal1612
requested changes
Nov 27, 2024
Waiting for web pr google/ground-platform#2107 to get in so for the proto variable |
anandwana001
changed the title
|
Please add some test coverage to |
shobhitagarwal1612
requested changes
Nov 28, 2024
.../google/android/ground/persistence/remote/firebase/schema/SubmissionMutationConverterTest.kt
Show resolved
Hide resolved
shobhitagarwal1612
approved these changes
Nov 28, 2024
shobhitagarwal1612
deleted the
anandwana001/2846/add-text-other-if-empty
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2846
Added proto in this PR
google/ground-platform#2107
@shobhitagarwal1612 PTAL?