Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Handling for urlConnection #2902

Merged

remove test

1dabbe2
Select commit
Loading
Failed to load commit list.
Merged

Error Handling for urlConnection #2902

remove test
1dabbe2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 7, 2025 in 0s

62.87% (-0.11%) compared to 102e87d

View this Pull Request on Codecov

62.87% (-0.11%) compared to 102e87d

Details

Codecov Report

Attention: Patch coverage is 15.38462% with 22 lines in your changes missing coverage. Please review.

Project coverage is 62.87%. Comparing base (102e87d) to head (1dabbe2).

Files with missing lines Patch % Lines
...lineareas/selector/OfflineAreaSelectorViewModel.kt 5.88% 16 Missing ⚠️
...flineareas/selector/OfflineAreaSelectorFragment.kt 37.50% 1 Missing and 4 partials ⚠️
...android/ground/repository/OfflineAreaRepository.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2902      +/-   ##
============================================
- Coverage     62.97%   62.87%   -0.11%     
- Complexity     1287     1288       +1     
============================================
  Files           273      273              
  Lines          6723     6739      +16     
  Branches        933      937       +4     
============================================
+ Hits           4234     4237       +3     
- Misses         1872     1882      +10     
- Partials        617      620       +3     
Files with missing lines Coverage Δ
...le/android/ground/ui/map/gms/mog/UrlInputStream.kt 0.00% <ø> (ø)
...android/ground/repository/OfflineAreaRepository.kt 49.18% <0.00%> (ø)
...flineareas/selector/OfflineAreaSelectorFragment.kt 35.00% <37.50%> (-0.19%) ⬇️
...lineareas/selector/OfflineAreaSelectorViewModel.kt 28.72% <5.88%> (-2.23%) ⬇️