Skip to content

Commit

Permalink
Upgrade to a version of plexus-io from after a performance improvem…
Browse files Browse the repository at this point in the history
…ent was restored.

(See codehaus-plexus/plexus-io#109.)

This CL _shouldn't_ make a performance difference because cl/650419894 _should_ have moved us to a version before the performance improvement was originally reverted. However, I messed that prior CL up, pinning us to the slow 3.4.1 instead of the fast 3.3.1. So in fact this CL _does_ improve performance back to the point it was at for 3.3.1. Today, that means an improvement from ~75s to ~1s for a clean `mvn source:jar-no-fork -f guava` on our Google workstations.

RELNOTES=n/a
PiperOrigin-RevId: 686509316
  • Loading branch information
cpovirk authored and Google Java Core Libraries committed Oct 16, 2024
1 parent 0a29129 commit 5338f7c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions android/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -263,8 +263,8 @@
<dependency>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-io</artifactId>
<!-- DO NOT UPGRADE this past 3.4.1 until https://github.com/codehaus-plexus/plexus-io/issues/109 is fixed (probably in 3.5.1). -->
<version>3.4.1</version>
<!-- We need at least 3.5.1 to avoid https://github.com/codehaus-plexus/plexus-io/issues/109. Once we upgrade maven-source-plugin itself to a version new enough to depend on 3.5.1 or higher, we can remove this override. -->
<version>3.5.1</version>
</dependency>
</dependencies>
</plugin>
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -264,8 +264,8 @@
<dependency>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-io</artifactId>
<!-- DO NOT UPGRADE this past 3.4.1 until https://github.com/codehaus-plexus/plexus-io/issues/109 is fixed (probably in 3.5.1). -->
<version>3.4.1</version>
<!-- We need at least 3.5.1 to avoid https://github.com/codehaus-plexus/plexus-io/issues/109. Once we upgrade maven-source-plugin itself to a version new enough to depend on 3.5.1 or higher, we can remove this override. -->
<version>3.5.1</version>
</dependency>
</dependencies>
</plugin>
Expand Down

0 comments on commit 5338f7c

Please sign in to comment.