Address [StaticQualifiedUsingExpression](https://errorprone.info/bugp…

…attern/StaticQualifiedUsingExpression) and [ExtendsObject](https://errorprone.info/bugpattern/ExtendsObject) warnings. RELNOTES=n/a PiperOrigin-RevId: 686893871
google · Oct 17, 2024 · dc423d2 · dc423d2
1 parent 2212495
commit dc423d2
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/android/guava-tests/test/com/google/common/reflect/TypesTest.java b/android/guava-tests/test/com/google/common/reflect/TypesTest.java
@@ -257,7 +257,16 @@ private static class WithTypeVariable {
     @SuppressWarnings("unused")
     <T> void withoutBound(List<T> list) {}
 
-    @SuppressWarnings("unused")
+    @SuppressWarnings({
+      "unused",
+      /*
+       * Since reflection can't tell the difference between <T> and <T extends Object>, it doesn't
+       * make a ton of sense to have a separate tests for each. But having tests for each doesn't
+       * really hurt anything, and maybe it will serve a purpose in a future in which Java has a
+       * built-in nullness feature?
+       */
+      "ExtendsObject",
+    })
     <T extends Object> void withObjectBound(List<T> list) {}
 
     @SuppressWarnings("unused")

diff --git a/guava-tests/test/com/google/common/reflect/TypesTest.java b/guava-tests/test/com/google/common/reflect/TypesTest.java
@@ -257,7 +257,16 @@ private static class WithTypeVariable {
     @SuppressWarnings("unused")
     <T> void withoutBound(List<T> list) {}
 
-    @SuppressWarnings("unused")
+    @SuppressWarnings({
+      "unused",
+      /*
+       * Since reflection can't tell the difference between <T> and <T extends Object>, it doesn't
+       * make a ton of sense to have a separate tests for each. But having tests for each doesn't
+       * really hurt anything, and maybe it will serve a purpose in a future in which Java has a
+       * built-in nullness feature?
+       */
+      "ExtendsObject",
+    })
     <T extends Object> void withObjectBound(List<T> list) {}
 
     @SuppressWarnings("unused")