Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clone of https://github.com/google/guava/pull/6730 but with Windows testing on JDK8 #6731

Closed
wants to merge 4 commits into from

Conversation

cpovirk
Copy link
Member

@cpovirk cpovirk commented Sep 26, 2023

Fix Files.createTempDir and FileBackedOutputStream under Windows services, a rare use case.

Fixes #6634

Relevant to #2686 in that it shows that we would ideally run our Windows testing under both Java 8 and a newer version....

RELNOTES=io: Fixed Files.createTempDir and FileBackedOutputStream under Windows services, a rare use case.
PiperOrigin-RevId: 568604081

Fix `Files.createTempDir` and `FileBackedOutputStream` under Windows _services_, a rare use case.

Fixes #6634

Relevant to #2686 in that it shows that we would ideally run our Windows testing under both Java 8 *and* a newer version....

RELNOTES=`io`: Fixed `Files.createTempDir` and `FileBackedOutputStream` under [Windows _services_, a rare use case](#6634).
PiperOrigin-RevId: 568604081
@cpovirk
Copy link
Member Author

cpovirk commented Sep 26, 2023

The failure is an unrelated problem, so I think this is behaving as hoped on Windows under Java 8.

That failure:

  testServiceStartupTimes(com.google.common.util.concurrent.ServiceManagerTest): expected to be at least: 150

During the course of this testing, I've also seen a failure in a near-identical test:

  testServiceStartupDurations(com.google.common.util.concurrent.ServiceManagerTest): expected to be at least: PT0.15S

Here's the full version of the first failure:

testServiceStartupTimes(com.google.common.util.concurrent.ServiceManagerTest)  Time elapsed: 0.362 sec  <<< FAILURE!
expected to be at least: 150
but was                : 146
	at com.google.common.util.concurrent.ServiceManagerTest.testServiceStartupTimes(ServiceManagerTest.java:131)

I suspect that I've seen it only during these Windows Java 8 tests, so I may set up the test to no longer run in that environment (not that we run CI for Windows Java 8, anyway). (As with the other Windows slowness we've seen, I wouldn't be surprised if the problem were less "Windows" and more "emulation.")

@cpovirk cpovirk closed this Sep 26, 2023
@cpovirk cpovirk deleted the java8-568604081 branch September 26, 2023 21:03
copybara-service bot pushed a commit that referenced this pull request Oct 2, 2023
I've found them to be [flaky](#6731 (comment)). We already [skip](#2130) some tests under Windows, so what's two more (especially only under Java 8, which I didn't include when setting up [Windows CI](#2686) and which I was testing only as part of #6634)?

RELNOTES=n/a
PiperOrigin-RevId: 568645480
copybara-service bot pushed a commit that referenced this pull request Oct 2, 2023
I've found them to be [flaky](#6731 (comment)). We already [skip](#2130) some tests under Windows, so what's two more (especially only under Java 8, which I didn't include when setting up [Windows CI](#2686) and which I was testing only as part of #6634)?

RELNOTES=n/a
PiperOrigin-RevId: 570103461
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant