Standardize on sneakyThrow for "impossible" checked exceptions.
#7579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
This makes our code behave the same for sneaky checked exceptions that occur _when our implementations use reflection_ as for those that occur when our implementations use direct calls. This shouldn't matter for any of the code that I'm migrating to `sneakyThrow` in this CL, but there are other cases in which it could matter, and we're probably best off standardizing on one approach, just as we've done for _catching_ sneaky checked exceptions. Plus, pull each package's `sneakyThrow` out into its own top-level class for reuse. Also, sneak in a few other tiny cleanups: - We don't normally use `@GwtCompatible` in Truth, so remove it from `J2ktIncompatible`. - We can now use `Primitives.wrap` to produce a better error message for `isIntanceOf(primitiveType)`. RELNOTES=n/a PiperOrigin-RevId: 710111747
copybara-service
bot
force-pushed
the
test_710060382
branch
from
0782e12 to
1462a03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardize on
sneakyThrowfor "impossible" checked exceptions.This makes our code behave the same for sneaky checked exceptions that occur when our implementations use reflection as for those that occur when our implementations use direct calls.
This shouldn't matter for any of the code that I'm migrating to
sneakyThrowin this CL, but there are other cases in which it could matter, and we're probably best off standardizing on one approach, just as we've done for catching sneaky checked exceptions.Plus, pull each package's
sneakyThrowout into its own top-level class for reuse.Also, sneak in a few other tiny cleanups:
@GwtCompatiblein Truth, so remove it fromJ2ktIncompatible.Primitives.wrapto produce a better error message forisIntanceOf(primitiveType).RELNOTES=n/a