Use JDK 23 for generating Javadoc, too. #7596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
This brings us to the newest released version, which also means that it matches the version that we use for javac, so we require one less JDK. cl/711811272 fixed [the error we'd previously been seeing with JDK 23](#6790 (comment)). (Also, if someone has a JDK 23 already installed and skips our auto-downloading, use it even if it's not Temurin. I'd made this change for most toolchain usages in cl/711746683, but I missed the usage one for Javadoc.) RELNOTES=n/a PiperOrigin-RevId: 711839263
copybara-service
bot
force-pushed
the
test_711829376
branch
from
90f5cd1 to
ff7c071
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use JDK 23 for generating Javadoc, too.
This brings us to the newest released version, which also means that it matches the version that we use for javac, so we require one less JDK.
cl/711811272 fixed the error we'd previously been seeing with JDK 23.
(Also, if someone has a JDK 23 already installed and skips our auto-downloading, use it even if it's not Temurin. I'd made this change for most toolchain usages in cl/711746683, but I missed the usage one for Javadoc.)
RELNOTES=n/a