Make UnsignedBytes.lexicographicalComparator()
use Arrays.compareUnsigned
when it's available.
#7611
+0
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
UnsignedBytes.lexicographicalComparator()
useArrays.compareUnsigned
when it's available.This provides another alternative to using
Unsafe
.And port the benchmark to JMH, which for now means making it Google-internal. (Not that we have our Caliper benchmarks actually running externally, either, IIRC.)
The benchmarks suggest that the old,
Unsafe
-based implementation is faster up to 64 elements or so but that it's a matter of only about a nanosecond. The new implementation pulls ahead for larger arrays, including an advantage of about 5-10 ns for 1024 elements.For now, I've included this implementation only in the JRE flavor of Guava. We could include it in the Android flavor, too, to see if it helps under API Level 33+. But we really would want to do yet more benchmarking for that.
RELNOTES=n/a