[runsc] Print file name when cannot load state file #11457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepancheg
force-pushed
the
state-file
branch
from
2780971 to
f0ac6d5
Compare
ayushr2
approved these changes
Feb 10, 2025
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 10, 2025
When `runsc` does not work, there are messages like ``` loading container: file does not exist ... loading sandbox: file does not exist ``` The problem here is, there is no indication of file path, making it harder to debug. I don't have access to environment where these errors appear, so I cannot repro. Better diagnostics would help. There's a comment in code suggesting that error code is important, so we cannot modify error IIUC https://github.com/google/gvisor/blob/9c490f813d37882f0374b7aebdad9961277623b8/runsc/container/state_file.go#L81 so my suggestion is to log the file name. FUTURE_COPYBARA_INTEGRATE_REVIEW=#11457 from stepancheg:state-file f0ac6d5 PiperOrigin-RevId: 725255102
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
When `runsc` does not work, there are messages like ``` loading container: file does not exist ... loading sandbox: file does not exist ``` The problem here is, there is no indication of file path, making it harder to debug. I don't have access to environment where these errors appear, so I cannot repro. Better diagnostics would help. There's a comment in code suggesting that error code is important, so we cannot modify error IIUC https://github.com/google/gvisor/blob/9c490f813d37882f0374b7aebdad9961277623b8/runsc/container/state_file.go#L81 so my suggestion is to log the file name. FUTURE_COPYBARA_INTEGRATE_REVIEW=#11457 from stepancheg:state-file f0ac6d5 PiperOrigin-RevId: 725255102
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
When `runsc` does not work, there are messages like ``` loading container: file does not exist ... loading sandbox: file does not exist ``` The problem here is, there is no indication of file path, making it harder to debug. I don't have access to environment where these errors appear, so I cannot repro. Better diagnostics would help. There's a comment in code suggesting that error code is important, so we cannot modify error IIUC https://github.com/google/gvisor/blob/9c490f813d37882f0374b7aebdad9961277623b8/runsc/container/state_file.go#L81 so my suggestion is to log the file name. FUTURE_COPYBARA_INTEGRATE_REVIEW=#11457 from stepancheg:state-file f0ac6d5 PiperOrigin-RevId: 725255102
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
When `runsc` does not work, there are messages like ``` loading container: file does not exist ... loading sandbox: file does not exist ``` The problem here is, there is no indication of file path, making it harder to debug. I don't have access to environment where these errors appear, so I cannot repro. Better diagnostics would help. There's a comment in code suggesting that error code is important, so we cannot modify error IIUC https://github.com/google/gvisor/blob/9c490f813d37882f0374b7aebdad9961277623b8/runsc/container/state_file.go#L81 so my suggestion is to log the file name. FUTURE_COPYBARA_INTEGRATE_REVIEW=#11457 from stepancheg:state-file f0ac6d5 PiperOrigin-RevId: 725255102
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 12, 2025
When `runsc` does not work, there are messages like ``` loading container: file does not exist ... loading sandbox: file does not exist ``` The problem here is, there is no indication of file path, making it harder to debug. I don't have access to environment where these errors appear, so I cannot repro. Better diagnostics would help. There's a comment in code suggesting that error code is important, so we cannot modify error IIUC https://github.com/google/gvisor/blob/9c490f813d37882f0374b7aebdad9961277623b8/runsc/container/state_file.go#L81 so my suggestion is to log the file name. FUTURE_COPYBARA_INTEGRATE_REVIEW=#11457 from stepancheg:state-file f0ac6d5 PiperOrigin-RevId: 725255102
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 12, 2025
When `runsc` does not work, there are messages like ``` loading container: file does not exist ... loading sandbox: file does not exist ``` The problem here is, there is no indication of file path, making it harder to debug. I don't have access to environment where these errors appear, so I cannot repro. Better diagnostics would help. There's a comment in code suggesting that error code is important, so we cannot modify error IIUC https://github.com/google/gvisor/blob/9c490f813d37882f0374b7aebdad9961277623b8/runsc/container/state_file.go#L81 so my suggestion is to log the file name. FUTURE_COPYBARA_INTEGRATE_REVIEW=#11457 from stepancheg:state-file f0ac6d5 PiperOrigin-RevId: 725255102
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
runscdoes not work, there are messages likeThe problem here is, there is no indication of file path, making it harder to debug.
I don't have access to environment where these errors appear, so I cannot repro. Better diagnostics would help.
There's a comment in code suggesting that error code is important, so we cannot modify error IIUC
gvisor/runsc/container/state_file.go
Line 81 in 9c490f8
so my suggestion is to log the file name.