Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[runsc] When mount files, add arguments to error message #11458

Merged
merged 1 commit into from
Feb 10, 2025
Merged

[runsc] When mount files, add arguments to error message #11458

merged 1 commit into from
Feb 10, 2025

Conversation

stepancheg
Copy link
Contributor

@stepancheg stepancheg commented Feb 9, 2025 •
edited
Loading

I see an error like

W0209 17:31:57.513990       1 util.go:64] FATAL ERROR: error setting up chroot: error converting mounts: permission denied

and have no idea, what operation exactly fails.

@stepancheg stepancheg marked this pull request as ready for review February 9, 2025 17:50
ayushr2
ayushr2 reviewed Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@ayushr2 ayushr2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

runsc/specutils/specutils.go Outdated Show resolved Hide resolved
@stepancheg stepancheg requested a review from ayushr2 February 10, 2025 17:58
copybara-service bot pushed a commit that referenced this pull request Feb 10, 2025
@stepancheg @gvisor-bot
[runsc] When mount files, add arguments to error message
ced22e6 
I see an error like

```
W0209 17:31:57.513990       1 util.go:64] FATAL ERROR: error setting up chroot: error converting mounts: permission denied
```

and have no idea, what operation exactly fails.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#11458 from stepancheg:mount 522d089
PiperOrigin-RevId: 725257497
@copybara-service copybara-service bot mentioned this pull request Feb 10, 2025
Merged
copybara-service bot pushed a commit that referenced this pull request Feb 10, 2025
@stepancheg @gvisor-bot
[runsc] When mount files, add arguments to error message
93689e6 
I see an error like

```
W0209 17:31:57.513990       1 util.go:64] FATAL ERROR: error setting up chroot: error converting mounts: permission denied
```

and have no idea, what operation exactly fails.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#11458 from stepancheg:mount 522d089
PiperOrigin-RevId: 725257497
copybara-service bot pushed a commit that referenced this pull request Feb 10, 2025
@stepancheg @gvisor-bot
[runsc] When mount files, add arguments to error message
4f08c71 
I see an error like

```
W0209 17:31:57.513990       1 util.go:64] FATAL ERROR: error setting up chroot: error converting mounts: permission denied
```

and have no idea, what operation exactly fails.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#11458 from stepancheg:mount 522d089
PiperOrigin-RevId: 725257497
@copybara-service copybara-service bot merged commit deaf50d into google:master Feb 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayushr2 ayushr2 ayushr2 approved these changes

Assignees
No one assigned
Labels
ready to pull
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stepancheg @ayushr2