Move AddAndKeySwitchCountAnalysis to a standalone pass #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZenithalHourlyRate
force-pushed
the
openfhe-count
branch
2 times, most recently
from
c4b3e87 to
69ef43e
Compare
ZenithalHourlyRate
force-pushed
the
openfhe-count
branch
from
69ef43e to
a90409a
Compare
j2kun
approved these changes
Feb 19, 2025
j2kun
added
the
pull_ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IR is stable only after
secret-insert-mgmt-bgvandoptimize-relinearization, yet the count analysis runs insecret-insert-mgmt-bgv, which will result in an incorrect result.Also only annotate
addCountandkeySwitchCountfor each SSA when debugging to avoid poluting the IR.The pass lives in
lib/Dialect/Openfheas it is openfhe specific though it is quite early in the pipeline, see also #1420.