Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #!/usr/bin/env node to the top of the cli/index.ts #41

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Add #!/usr/bin/env node to the top of the cli/index.ts #41

merged 1 commit into from
Oct 6, 2020

Conversation

dmitryrn
Copy link
Contributor

@dmitryrn dmitryrn commented Sep 26, 2020

That will make executing via npx working. (#36). tsc will build it without error.

Add #!/usr/bin/env node to the top of the cli/index.ts
@google-cla
Copy link

google-cla bot commented Sep 26, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@dmitryrn
Copy link
Contributor Author

@googlebot I signed it!

@ryanmcdermott
Copy link
Member

Thanks!

@ryanmcdermott ryanmcdermott merged commit 9c04057 into google:master Oct 6, 2020
@jasco
Copy link

jasco commented Oct 9, 2020

It appears as if npm release 0.2.4, which should includes this patch, didn't get rebuilt before distribution? The shebang is missing from the build/src/cli/index.js file in the npm install. If I manually build it locally, the shebang does appear in the header as expected.

(Looking at the diff after rebuild it looks like at least the outputFormat option was missing from the build as well.)

@ryanmcdermott
Copy link
Member

It's really strange, I could swear I re-built it. In my rather inadequate defense, I must say I'm not a Node expert actually. I'm not a self-professed member of the wider JS/TS community anymore.

For what it's worth, I ran npm link locally to verify that it worked globally and checked the build dates via ls -al and it looks correct in version 0.2.5. Let me know if this fixes it!

Sorry for the back and forth, thanks for all your help!

@jasco
Copy link

jasco commented Oct 9, 2020

Version 0.2.5 does work as expected for me now. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants