feat: add doc for std.parseCsv and std.manifestCsv #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sparkprime is it fine to break the compatibility for these functions in cpp implementation? |
rohitjangid
force-pushed
the
feat/csv
branch
2 times, most recently
from
7df78a0
to
a8bebc3
Compare
|
Yes I think we can break compatibility for newly introduced library functions at this point. |
sparkprime
reviewed
May 25, 2023
| If <code>json</code> param is not a valid csv compatible object, it would be an error. | ||
| |||), | ||
| html.p({}, ||| | ||
| The <code>headers</code> param adds is an optional which would default to all fields in the object. |
There was a problem hiding this comment.
It only looks at the first row, though.
sparkprime
reviewed
Jun 13, 2023
| @@ -681,6 +681,20 @@ local html = import 'html.libsonnet'; | |||
| }, | |||
| ], | |||
| }, | |||
| { | |||
| name: 'parseCsv', | |||
There was a problem hiding this comment.
Needs updating to the new name
sparkprime
reviewed
Jun 13, 2023
| params: ['str', 'delimiter=","'], | ||
| availableSince: 'upcoming', | ||
| description: ||| | ||
| Parses a CSV string into JSON. |
There was a problem hiding this comment.
Needs to mention how the first row is interpreted as a header row and must have unique column names, which then are used as fields in the JSON representation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add doc for
std.parseCsvWithHeaderandstd.manifestCsvgo-jsonnet PR: google/go-jsonnet#701