feat: add |||- chomped text block syntax
#1175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
vergenzt
added a commit
to vergenzt/go-jsonnet
that referenced
this pull request
Oct 11, 2024
Resolves google/jsonnet#289 Companion PR to google/jsonnet#1175
This was referenced Oct 11, 2024
|
Any updates? Anybody willing to review this and weigh in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #289!
Was pretty easy to add as you can see. 🙂
Let me know if you have any concerns or feedback!
Only part I'm not sure of is the changes to doc/third_party/MathJax-2.7.2/unpacked -- it looks like like at
jsonnet/doc/_layouts/base.html
Line 22 in 9952fc5
MathJax.js, but I can't figure out to re-"pack" the unpacked code. 🤔 I'm also not sure how critical it is though. 🤷🏻♂️Note: I'm working on a companion PR to google/go-jsonnet too.